test: Remove unused, undocumented and misleading CScript.add
ClosedPublic
Actions

Authored by PiRK on Jan 19 2021, 16:15.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb92af5e5d4c1: test: Remove unused, undocumented and misleading CScript.__add__

Summary

CScript is a subclass of bytes. This removes the overloaded implementation of CScript.__add__ and ensures that it raises an error instead of calling bytes.__add__.

This is a backport of Core PR18732

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 19 2021, 16:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2021, 16:15

PiRK requested review of this revision.Jan 19 2021, 16:15

teamcity edited the summary of this revision. (Show Details)Jan 19 2021, 16:15

Harbormaster completed remote builds in B14842: Diff 27075.Jan 19 2021, 16:29

Fabien accepted this revision.Jan 19 2021, 16:48

This revision is now accepted and ready to land.Jan 19 2021, 16:48

Closed by commit rABCb92af5e5d4c1: test: Remove unused, undocumented and misleading CScript.__add__ (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 19 2021, 17:07

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb92af5e5d4c1: test: Remove unused, undocumented and misleading CScript.__add__.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

script.py

12 lines

Diff 27087

View Options

test/functional/test_framework/script.py

test: Remove unused, undocumented and misleading CScript.__add__ClosedPublicActions