HomePhabricator

test: Remove unused, undocumented and misleading CScript.__add__

Description

test: Remove unused, undocumented and misleading CScript.add

Summary:
CScript is a subclass of bytes. This removes the overloaded implementation of CScript.__add__ and ensures that it raises an error instead of calling bytes.__add__.

This is a backport of Core PR18732

Test Plan: ninja check-functional-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8960

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Jan 19 2021, 17:00
PiRKCommitted on Jan 19 2021, 17:01
abc-botPushed on Jan 19 2021, 17:07
Reviewer
Restricted Project
Differential Revision
D8960: test: Remove unused, undocumented and misleading CScript.__add__
Parents
rABC5a29b7c62366: fuzz: Add missing ECC_Start to key_io test
Branches
Unknown
Tags
Unknown