Page MenuHomePhabricator

test: display command line options passed to send_cli() in debug log
ClosedPublic

Authored by PiRK on Jan 19 2021, 16:41.

Details

Summary

Co-authored-by: MarcoFalke <falke.marco@gmail.com>

The changes in interface_bitcoin_cli.py were already applied in our codebase.

This is a backport of Core PR18712

Test Plan

Add a failure (assert False) in interface_bitcoin_cli.py after a call to send_cli()
Check the presence of the new debug message in the log, just before the failure.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Jan 19 2021, 16:41

move the log before adding the emulator (the emulator is specific to ABC)

This revision is now accepted and ready to land.Jan 19 2021, 16:58

Tail of the build log:

wallet_multiwallet.py                            | ✓ Passed  | 12 s
wallet_multiwallet.py --usecli                   | ✓ Passed  | 13 s
wallet_reorgsrestore.py                          | ✓ Passed  | 3 s
wallet_resendwallettransactions.py               | ✓ Passed  | 4 s
wallet_txn_clone.py                              | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock                  | ✓ Passed  | 4 s
wallet_txn_doublespend.py                        | ✓ Passed  | 2 s
wallet_txn_doublespend.py --mineblock            | ✓ Passed  | 4 s
wallet_watchonly.py                              | ✓ Passed  | 1 s
wallet_watchonly.py --usecli                     | ✓ Passed  | 1 s
wallet_zapwallettxes.py                          | ✓ Passed  | 4 s

ALL                                              | ✓ Passed  | 1176 s (accumulated) 
Runtime: 236 s

[147/438] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[148/438] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.003s

OK
[175/438] Running avalanche test suite
PASSED: avalanche test suite
[188/438] Running seeder test suite
PASSED: seeder test suite
[195/438] Running secp256k1 test suite
PASSED: secp256k1 test suite
[371/438] bitcoin: testing finalization_tests
FAILED: src/test/CMakeFiles/check-bitcoin-finalization_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-finalization_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=finalization_tests --logger=HRF,message:JUNIT,message,bitcoin-finalization_tests.xml --catch_system_errors=no
Running 1 test case...
../../src/test/finalization_tests.cpp(59): error: in "finalization_tests/finalizationDelay": Block finalized at height 107 (tip at height 117)
../../src/test/finalization_tests.cpp(59): error: in "finalization_tests/finalizationDelay": Block finalized at height 108 (tip at height 118)
../../src/test/finalization_tests.cpp(59): error: in "finalization_tests/finalizationDelay": Block finalized at height 109 (tip at height 119)
../../src/test/finalization_tests.cpp(59): error: in "finalization_tests/finalizationDelay": Block finalized at height 110 (tip at height 120)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 121)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 122)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 123)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 124)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 125)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 126)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 127)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 128)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 129)
../../src/test/finalization_tests.cpp(72): error: in "finalization_tests/finalizationDelay": Finalized block remains unchanged at height 110 (tip at height 130)

*** 14 failures are detected in the test module "Bitcoin ABC unit tests"
[409/438] Running pow test suite
PASSED: pow test suite
[431/438] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[435/438] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1