Paths

Table of Contentst

Differential D8974

refactor: test: use wait_for_getdata() in p2p_compactblocks.py
ClosedPublic
Actions

Authored by PiRK on Jan 20 2021, 08:53.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9d4e2e9eedb4: refactor: test: use wait_for_getdata() in p2p_compactblocks.py

Summary

The method wait_for_getdata() was recently changed to be more precise by waiting for a specified list of hashes, instead of only matching any getdata message (see PR18690). This PR replaces the remaining occurences of manual inspection of last_messages with this call.

This is a backport of Core PR18756

Test Plan

test/functional/test_runner.py p2p_compactblocks

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 20 2021, 08:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2021, 08:53

PiRK requested review of this revision.Jan 20 2021, 08:53

teamcity edited the summary of this revision. (Show Details)Jan 20 2021, 08:53

Harbormaster completed remote builds in B14858: Diff 27106.Jan 20 2021, 09:14

Fabien accepted this revision.Jan 20 2021, 10:28

This revision is now accepted and ready to land.Jan 20 2021, 10:28

Closed by commit rABC9d4e2e9eedb4: refactor: test: use wait_for_getdata() in p2p_compactblocks.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyJan 20 2021, 11:14

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9d4e2e9eedb4: refactor: test: use wait_for_getdata() in p2p_compactblocks.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_compactblocks.py

14 lines

Diff 27118

test/functional/p2p_compactblocks.py

Loading...