Page MenuHomePhabricator

[trivial] Remove misleading 'const'
ClosedPublic

Authored by PiRK on Jan 22 2021, 09:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdbfdb444f57a: [trivial] Remove misleading 'const'
Summary

Returning by const value is only meaningful in a specific circumstance around
user defined types. In this case, the const is not enforcing any restrictions
on the call site, so is misleading.

This is a backport of Core PR18807 [7/9]
https://github.com/bitcoin/bitcoin/pull/18807/commits/750456d6f29c63d57af05bfbdd6035bb9c965de2

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable