Page MenuHomePhabricator

[Cashtab] Add unit tests for function that sends BCHA
AbandonedPublic

Authored by bytesofman on Jan 25 2021, 22:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Add more unit tests for the sendBch function. This is a preparatory diff for making decimal places of base unit arbitrary throughout Cashtab.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
more-sendbch-unit-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15003
Build 29957: Build Diffcashtab-tests
Build 29956: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jan 26 2021, 10:28
Fabien added a subscriber: Fabien.

Before this diff I would cause a test failure by changing the default fee, which is bad.
After this diff I would cause 3 test failures by changing the default fee, which is worst.

This revision now requires changes to proceed.Jan 26 2021, 10:28

Refactor unit tests for standardized fee levels

Abandoned in favor of alternative approach provided by (landed) D9088

Abandoned in favor of alternative approach provided by (landed) D9088