Page MenuHomePhabricator
Differential D9056

[Cashtab] Add unit tests for function that sends BCHA
AbandonedPublic
Actions

Authored by bytesofman on Jan 25 2021, 22:14.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Add more unit tests for the sendBch function. This is a preparatory diff for making decimal places of base unit arbitrary throughout Cashtab.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
more-sendbch-unit-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15003
Build 29957: Build Diffcashtab-tests
Build 29956: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 25 2021, 22:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2021, 22:14
bytesofman requested review of this revision.Jan 25 2021, 22:14
Harbormaster completed remote builds in B14983: Diff 27310.Jan 25 2021, 22:18
Fabien requested changes to this revision.Jan 26 2021, 10:28
Fabien added a subscriber: Fabien.

Before this diff I would cause a test failure by changing the default fee, which is bad.
After this diff I would cause 3 test failures by changing the default fee, which is worst.

This revision now requires changes to proceed.Jan 26 2021, 10:28
bytesofman updated this revision to Diff 27344.Jan 26 2021, 21:22

Refactor unit tests for standardized fee levels

Harbormaster completed remote builds in B15003: Diff 27344.Jan 26 2021, 21:25
bytesofman abandoned this revision.Jan 28 2021, 11:20

Abandoned in favor of alternative approach provided by (landed) D9088

bytesofman added a comment.Jan 28 2021, 11:41

Abandoned in favor of alternative approach provided by (landed) D9088

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Common/
9 lines
hooks/
__mocks__/
42 lines
__tests__/
105 lines

Diff 27344

View Options

web/cashtab/src/components/Common/Ticker.js

Loading...
View Options

web/cashtab/src/hooks/__mocks__/sendBCH.js

Loading...
View Options

web/cashtab/src/hooks/__tests__/useBCH.test.js

Loading...