Page MenuHomePhabricator

[Cashtab] Make tx fee in sats/byte a param
ClosedPublic

Authored by josephroyking on Jan 27 2021, 20:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfab1e777785a: [Cashtab] Make tx fee in sats/byte a param
Summary

Add feeInSatsPerByte as a param in the sendBch function. This allows unit tests to use a constant.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/cashtab/src/hooks/__tests__/useBCH.test.js
47 ↗(On Diff #27373)

Nit: the above comment and variable are no longer necessary, expect(calcFee(BCH, utxosMock, 2, 1.01)).toBe(378); is just as easy to read and understand imo

This revision is now accepted and ready to land.Jan 28 2021, 08:17