Page MenuHomePhabricator
Differential D9088

[Cashtab] Make tx fee in sats/byte a param
ClosedPublic
Actions

Authored by bytesofman on Jan 27 2021, 20:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCfab1e777785a: [Cashtab] Make tx fee in sats/byte a param
Summary

Add feeInSatsPerByte as a param in the sendBch function. This allows unit tests to use a constant.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-fee-as-param
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15022
Build 29995: Build Diffcashtab-tests
Build 29994: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 27 2021, 20:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 20:04
bytesofman requested review of this revision.Jan 27 2021, 20:05
Harbormaster completed remote builds in B15022: Diff 27373.Jan 27 2021, 20:08
Fabien accepted this revision.Jan 28 2021, 08:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/cashtab/src/hooks/__tests__/useBCH.test.js
47

Nit: the above comment and variable are no longer necessary, expect(calcFee(BCH, utxosMock, 2, 1.01)).toBe(378); is just as easy to read and understand imo

This revision is now accepted and ready to land.Jan 28 2021, 08:17
Closed by commit rABCfab1e777785a: [Cashtab] Make tx fee in sats/byte a param (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJan 28 2021, 11:09
This revision was automatically updated to reflect the committed changes.
Joey King <joseph.roy.king@gmail.com> added a commit: rABCfab1e777785a: [Cashtab] Make tx fee in sats/byte a param.
bytesofman mentioned this in D9056: [Cashtab] Add unit tests for function that sends BCHA.Jan 28 2021, 11:20

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
1 line
hooks/
__mocks__/
9 lines
__tests__/
160 lines
15 lines

Diff 27373

View Options

web/cashtab/src/components/Send/Send.js

Loading...
View Options

web/cashtab/src/hooks/__mocks__/sendBCH.js

Loading...
View Options

web/cashtab/src/hooks/__tests__/useBCH.test.js

Loading...
View Options

web/cashtab/src/hooks/useBCH.js

Loading...