Page MenuHomePhabricator

fuzz: use std::optional for sep_pos variable
ClosedPublic

Authored by Fabien on Jan 26 2021, 10:57.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC04e0fd2b3eff: fuzz: use std::optional for sep_pos variable
Summary
This PR changes the original size_t sep_pos to std::optional<size_t>
sep_post_opt to remove the warning when compiling fuzz tests.

Backport of core PR18901.

Note that we don't have the warning for some reason.

Test Plan
ninja bitcoin-fuzzers
./src/test/fuzz/asmap_direct <path_to_corpus>

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jan 26 2021, 10:57

Tail of the build log:

wallet_importmulti.py started
rpc_createmultisig.py passed, Duration: 2 s
wallet_keypool.py started
p2p_unrequested_blocks.py passed, Duration: 3 s
wallet_listsinceblock.py started
rpc_scantxoutset.py passed, Duration: 3 s
wallet_reorgsrestore.py started
wallet_keypool.py passed, Duration: 2 s
wallet_resendwallettransactions.py started
wallet_importmulti.py passed, Duration: 3 s
wallet_txn_clone.py --mineblock started
wallet_avoidreuse.py passed, Duration: 4 s
wallet_txn_doublespend.py --mineblock started
wallet_listsinceblock.py passed, Duration: 2 s
abc-cmdline.py started
wallet_reorgsrestore.py passed, Duration: 3 s
abc-finalize-block.py started
abc-cmdline.py passed, Duration: 2 s
abc-invalid-chains.py started
wallet_txn_clone.py --mineblock passed, Duration: 3 s
abc-mempool-coherence-on-activations.py started
abc-finalize-block.py passed, Duration: 2 s
abc-minimaldata.py started
wallet_txn_doublespend.py --mineblock passed, Duration: 3 s
abc-replay-protection.py started
abc-invalid-chains.py passed, Duration: 2 s
abc-schnorr.py started
wallet_resendwallettransactions.py passed, Duration: 5 s
abc-schnorrmultisig.py started
abc-mempool-coherence-on-activations.py passed, Duration: 2 s
abc-segwit-recovery.py started
abc-minimaldata.py passed, Duration: 2 s
feature_includeconf.py started
abc-replay-protection.py passed, Duration: 2 s
feature_reindex.py started
abc-schnorrmultisig.py passed, Duration: 2 s
mempool_accept.py started
abc-schnorr.py passed, Duration: 2 s
mining_basic.py started
abc-segwit-recovery.py passed, Duration: 2 s
p2p_blocksonly.py started
feature_includeconf.py passed, Duration: 2 s
p2p_disconnect_ban.py started
feature_reindex.py passed, Duration: 3 s
p2p_dos_header_tree.py started
mempool_accept.py passed, Duration: 2 s
p2p_filter.py started
mining_basic.py passed, Duration: 2 s
rpc_bind.py --ipv4 started
p2p_disconnect_ban.py passed, Duration: 2 s
rpc_bind.py --ipv6 started
rpc_bind.py --ipv4 passed, Duration: 2 s
rpc_getchaintips.py started
p2p_dos_header_tree.py passed, Duration: 2 s
rpc_setban.py started
p2p_filter.py passed, Duration: 2 s
rpc_txoutproof.py started
rpc_bind.py --ipv6 passed, Duration: 2 s
wallet_createwallet.py started
Build build-diff timed out after 1200.0s
This revision is now accepted and ready to land.Jan 26 2021, 12:27
This revision was landed with ongoing or failed builds.Jan 26 2021, 12:32
This revision was automatically updated to reflect the committed changes.