Differential D9060

fuzz: use std::optional for sep_pos variable
ClosedPublic
Actions

Authored by Fabien on Jan 26 2021, 10:57.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC04e0fd2b3eff: fuzz: use std::optional for sep_pos variable

Summary

This PR changes the original size_t sep_pos to std::optional<size_t>
sep_post_opt to remove the warning when compiling fuzz tests.

Backport of core PR18901.

Note that we don't have the warning for some reason.

Test Plan

ninja bitcoin-fuzzers
./src/test/fuzz/asmap_direct <path_to_corpus>

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR18901

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14987
Build 29925: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-debug · build-diff · build-clang · build-clang-tidy
Build 29924: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 26 2021, 10:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2021, 10:57

Fabien requested review of this revision.Jan 26 2021, 10:57

teamcity edited the summary of this revision. (Show Details)Jan 26 2021, 10:57

Harbormaster completed remote builds in B14987: Diff 27316.Jan 26 2021, 11:23

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[1mwallet_importmulti.py[0m started
[1mrpc_createmultisig.py[0m passed, Duration: 2 s
[1mwallet_keypool.py[0m started
[1mp2p_unrequested_blocks.py[0m passed, Duration: 3 s
[1mwallet_listsinceblock.py[0m started
[1mrpc_scantxoutset.py[0m passed, Duration: 3 s
[1mwallet_reorgsrestore.py[0m started
[1mwallet_keypool.py[0m passed, Duration: 2 s
[1mwallet_resendwallettransactions.py[0m started
[1mwallet_importmulti.py[0m passed, Duration: 3 s
[1mwallet_txn_clone.py --mineblock[0m started
[1mwallet_avoidreuse.py[0m passed, Duration: 4 s
[1mwallet_txn_doublespend.py --mineblock[0m started
[1mwallet_listsinceblock.py[0m passed, Duration: 2 s
[1mabc-cmdline.py[0m started
[1mwallet_reorgsrestore.py[0m passed, Duration: 3 s
[1mabc-finalize-block.py[0m started
[1mabc-cmdline.py[0m passed, Duration: 2 s
[1mabc-invalid-chains.py[0m started
[1mwallet_txn_clone.py --mineblock[0m passed, Duration: 3 s
[1mabc-mempool-coherence-on-activations.py[0m started
[1mabc-finalize-block.py[0m passed, Duration: 2 s
[1mabc-minimaldata.py[0m started
[1mwallet_txn_doublespend.py --mineblock[0m passed, Duration: 3 s
[1mabc-replay-protection.py[0m started
[1mabc-invalid-chains.py[0m passed, Duration: 2 s
[1mabc-schnorr.py[0m started
[1mwallet_resendwallettransactions.py[0m passed, Duration: 5 s
[1mabc-schnorrmultisig.py[0m started
[1mabc-mempool-coherence-on-activations.py[0m passed, Duration: 2 s
[1mabc-segwit-recovery.py[0m started
[1mabc-minimaldata.py[0m passed, Duration: 2 s
[1mfeature_includeconf.py[0m started
[1mabc-replay-protection.py[0m passed, Duration: 2 s
[1mfeature_reindex.py[0m started
[1mabc-schnorrmultisig.py[0m passed, Duration: 2 s
[1mmempool_accept.py[0m started
[1mabc-schnorr.py[0m passed, Duration: 2 s
[1mmining_basic.py[0m started
[1mabc-segwit-recovery.py[0m passed, Duration: 2 s
[1mp2p_blocksonly.py[0m started
[1mfeature_includeconf.py[0m passed, Duration: 2 s
[1mp2p_disconnect_ban.py[0m started
[1mfeature_reindex.py[0m passed, Duration: 3 s
[1mp2p_dos_header_tree.py[0m started
[1mmempool_accept.py[0m passed, Duration: 2 s
[1mp2p_filter.py[0m started
[1mmining_basic.py[0m passed, Duration: 2 s
[1mrpc_bind.py --ipv4[0m started
[1mp2p_disconnect_ban.py[0m passed, Duration: 2 s
[1mrpc_bind.py --ipv6[0m started
[1mrpc_bind.py --ipv4[0m passed, Duration: 2 s
[1mrpc_getchaintips.py[0m started
[1mp2p_dos_header_tree.py[0m passed, Duration: 2 s
[1mrpc_setban.py[0m started
[1mp2p_filter.py[0m passed, Duration: 2 s
[1mrpc_txoutproof.py[0m started
[1mrpc_bind.py --ipv6[0m passed, Duration: 2 s
[1mwallet_createwallet.py[0m started
Build build-diff timed out after 1200.0s

PiRK accepted this revision.Jan 26 2021, 12:27

This revision is now accepted and ready to land.Jan 26 2021, 12:27

This revision was landed with ongoing or failed builds.Jan 26 2021, 12:32

Closed by commit rABC04e0fd2b3eff: fuzz: use std::optional for sep_pos variable (authored by Harris <brakmic@gmail.com>, committed by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC04e0fd2b3eff: fuzz: use std::optional for sep_pos variable.