rpc: Do not advertise dumptxoutset as a way to flush the chainstate
ClosedPublic
Actions

Authored by PiRK on Jan 26 2021, 17:12.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7239f66265e1: rpc: Do not advertise dumptxoutset as a way to flush the chainstate

Summary

The help message leaks several implementation details: leveldb and flush.

Neither of them are relevant to the end user and I don't see why we should make them part of the API contract.

This is a backport of Core PR18809

Test Plan

src/bitcoin-cli help dumptxoutset

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 26 2021, 17:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2021, 17:12

PiRK requested review of this revision.Jan 26 2021, 17:12

Harbormaster completed remote builds in B14995: Diff 27330.Jan 26 2021, 17:34

PiRK edited the summary of this revision. (Show Details)Jan 26 2021, 17:52

majcosta accepted this revision.Jan 26 2021, 18:55

This revision is now accepted and ready to land.Jan 26 2021, 18:55

Closed by commit rABC7239f66265e1: rpc: Do not advertise dumptxoutset as a way to flush the chainstate (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 26 2021, 19:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7239f66265e1: rpc: Do not advertise dumptxoutset as a way to flush the chainstate.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

3 lines

Diff 27338

View Options

rpc: Do not advertise dumptxoutset as a way to flush the chainstateClosedPublicActions