Differential D9085

[test] test that an invalid GETDATA doesn't prevent processing of future messages
ClosedPublic
Actions

Authored by PiRK on Jan 27 2021, 16:59.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCcd5131913fa9: [test] test that an invalid GETDATA doesn't prevent processing of future…

Summary

Co-Authored-By: John Newbery <john@johnnewbery.com>

This is a backport of Core PR18808 [3/4]
https://github.com/bitcoin/bitcoin/pull/18808/commits/2f032556e08a04807c71eb02104ca9589eaadf1b
Depends on D9084

Test Plan

ninja && test/functional/test_runner.py p2p_getdata

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15018
Build 29987: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 29986: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 27 2021, 16:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2021, 16:59

PiRK requested review of this revision.Jan 27 2021, 16:59

teamcity edited the summary of this revision. (Show Details)Jan 27 2021, 17:00

PiRK added a child revision: D9086: [docs] Improve commenting in ProcessGetData().Jan 27 2021, 17:02

PiRK edited the summary of this revision. (Show Details)

PiRK added a parent revision: D9084: [net processing] ignore unknown INV types in GETDATA messages.

Harbormaster completed remote builds in B15018: Diff 27367.Jan 27 2021, 17:37

majcosta accepted this revision.Jan 27 2021, 17:46

This revision is now accepted and ready to land.Jan 27 2021, 17:46

Closed by commit rABCcd5131913fa9: [test] test that an invalid GETDATA doesn't prevent processing of future… (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyJan 28 2021, 08:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCcd5131913fa9: [test] test that an invalid GETDATA doesn't prevent processing of future….

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_getdata.py

58 lines

Diff 27367

View Options

test/functional/p2p_getdata.py

[test] test that an invalid GETDATA doesn't prevent processing of future messagesClosedPublicActions