Paths

Table of Contentst

Differential D9100

[Cashtab] Clean up unit tests
ClosedPublic
Actions

Authored by bytesofman on Jan 28 2021, 12:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC857ffed14945: [Cashtab] Clean up unit tests

Summary

Delete duplicate/unused imports from useBCH.test.js; clarify unit test for attempt to send more than balance and make dependent on variable

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

unit-test-cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15038
Build 30027: Build Diff	cashtab-tests
Build 30026: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 28 2021, 12:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2021, 12:05

bytesofman requested review of this revision.Jan 28 2021, 12:05

Harbormaster completed remote builds in B15038: Diff 27400.Jan 28 2021, 12:08

Add 1.01 fee as constant in unit test to match previous version

Harbormaster completed remote builds in B15039: Diff 27401.Jan 28 2021, 12:11

Fabien accepted this revision.Jan 28 2021, 13:27

This revision is now accepted and ready to land.Jan 28 2021, 13:27

Closed by commit rABC857ffed14945: [Cashtab] Clean up unit tests (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJan 28 2021, 13:42

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABC857ffed14945: [Cashtab] Clean up unit tests.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

__tests__/

useBCH.test.js

37 lines

Diff 27400

View Options

web/cashtab/src/hooks/tests/useBCH.test.js

[Cashtab] Clean up unit testsClosedPublicActions