test: Remove RPCOverloadWrapper boilerplate
ClosedPublic
Actions

Authored by PiRK on Jan 28 2021, 13:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2c3f1596ee46: test: Remove RPCOverloadWrapper boilerplate

Summary

This is a backport of Core PR18888

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18888

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15040
Build 30031: Build Diff	build-clang · build-clang-tidy · build-without-wallet · build-diff · build-debug
Build 30030: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 28 2021, 13:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2021, 13:18

PiRK requested review of this revision.Jan 28 2021, 13:18

teamcity edited the summary of this revision. (Show Details)Jan 28 2021, 13:18

Harbormaster completed remote builds in B15040: Diff 27405.Jan 28 2021, 13:32

Can we try to make the dependency (PR16528) in first ? Otherwise at least put a comment so that we don't end up skipping the changes to create_wallet.

This revision now requires changes to proceed.Jan 28 2021, 13:38

Needs to be rebased and completed after PR16528 is finished (missing the createwallet method)

PiRK mentioned this in D10185: Add loadwallet and createwallet RPC load_on_startup options.Sep 22 2021, 14:36

PiRK mentioned this in rABC62bae4b8a97f: Add loadwallet and createwallet RPC load_on_startup options.Sep 27 2021, 12:58

rebase from hell and take care of createwallet

Harbormaster completed remote builds in B16799: Diff 30188.Sep 28 2021, 14:37

Fabien accepted this revision.Sep 28 2021, 18:50

This revision is now accepted and ready to land.Sep 28 2021, 18:50

Closed by commit rABC2c3f1596ee46: test: Remove RPCOverloadWrapper boilerplate (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhySep 29 2021, 06:16

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2c3f1596ee46: test: Remove RPCOverloadWrapper boilerplate.

PiRK mentioned this in D10213: Add a --descriptors option to various tests.Sep 29 2021, 13:57