test: Remove UninterruptibleSleep from test and replace it by SyncWithValidationInterfaceQueue
ClosedPublic
Actions

Authored by PiRK on Jan 28 2021, 14:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC66c052d5279f: test: Remove UninterruptibleSleep from test and replace it by…

Summary

For the purpose of this test the two have the same outcome, but this one
is shorter and avoids a sleep for 0.1 seconds.

This is a backport of Core PR18742 [2/3]
https://github.com/bitcoin/bitcoin/pull/18742/commits/fa5ceb25fce2200edf6b8ebfa6d4f01ed6774b95

Depends on D9103

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15043
Build 30037: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 30036: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 28 2021, 14:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2021, 14:29

PiRK requested review of this revision.Jan 28 2021, 14:29

teamcity edited the summary of this revision. (Show Details)Jan 28 2021, 14:29

PiRK edited the summary of this revision. (Show Details)Jan 28 2021, 14:32

PiRK added a parent revision: D9103: validationinterface: Rework documentation, Rename pwalletIn to callbacks.

PiRK added a child revision: D9105: miner: Avoid stack-use-after-return in validationinterface.

Harbormaster completed remote builds in B15043: Diff 27410.Jan 28 2021, 14:54

Fabien accepted this revision.Jan 28 2021, 15:33

This revision is now accepted and ready to land.Jan 28 2021, 15:33

Closed by commit rABC66c052d5279f: test: Remove UninterruptibleSleep from test and replace it by… (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyJan 28 2021, 17:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC66c052d5279f: test: Remove UninterruptibleSleep from test and replace it by….

Revision Contents
Changeset List

Path

Size

src/

test/

validation_block_tests.cpp

4 lines

Diff 27410

View Options

src/test/validation_block_tests.cpp

test: Remove UninterruptibleSleep from test and replace it by SyncWithValidationInterfaceQueueClosedPublicActions