Add attribute [[noreturn]] (C++11) to functions that will not return
ClosedPublic
Actions

Authored by deadalnix on Jan 7 2018, 00:45.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2936db1aebeb: Add attribute [[noreturn]] (C++11) to functions that will not return
rABC2936db1aebeb: Add attribute [[noreturn]] (C++11) to functions that will not return

Summary

Rationale:

Reduce the number of false positives from static analyzers
Potentially enable additional compiler optimizations

Backport of core's PR10843

Depends on D906

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 7 2018, 00:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2018, 00:45

Harbormaster completed remote builds in B1542: Diff 2391.Jan 7 2018, 00:45

schancel accepted this revision.Jan 7 2018, 20:07

This revision is now accepted and ready to land.Jan 7 2018, 20:07

Closed by commit rABC2936db1aebeb: Add attribute [[noreturn]] (C++11) to functions that will not return (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyJan 8 2018, 02:42

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

random.cpp

4 lines

test/

test_bitcoin_main.cpp

8 lines

Diff 2421

View Options

src/random.cpp