[net processing] Only send a getheaders for one block in an INV
ClosedPublic
Actions

Authored by PiRK on Jan 29 2021, 17:37.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCba0016fcc62e: [net processing] Only send a getheaders for one block in an INV

Summary

Headers-first is the primary method of announcement on the network. If a
node fell back sending blocks by inv, it's probably for a re-org. The
final block hash provided should be the highest, so send a getheaders
and then fetch the blocks we need to catch up.

This is a backport of Core PR18962

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18962

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15055
Build 30060: Build Diff	build-without-wallet · build-debug · build-clang · build-clang-tidy · lint-circular-dependencies · build-diff
Build 30059: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 29 2021, 17:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 29 2021, 17:37

PiRK requested review of this revision.Jan 29 2021, 17:37

teamcity edited the summary of this revision. (Show Details)Jan 29 2021, 17:37

Harbormaster completed remote builds in B15055: Diff 27430.Jan 29 2021, 17:50

Fabien requested changes to this revision.Jan 29 2021, 19:31

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
3025	This should be a `BlockHash`

This revision now requires changes to proceed.Jan 29 2021, 19:31

PiRK added inline comments.Jan 31 2021, 17:13

src/net_processing.cpp
3025	I tried this, but I did it wrong and the linter started yelling at me because I used a pointer to a local variable (`hash`) out of its scope. Also it requires removing the constness from `hash`. Marco suggested a solution with a `std::optional<BlockHash>`.