Page MenuHomePhabricator

refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o)
ClosedPublic

Authored by Fabien on Feb 1 2021, 13:40.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCe1f1d7ef991e: refactor: Replace HexStr(o.begin(), o.end()) with HexStr(o)
Summary
HexStr can be called with anything that bas begin() and end() functions,
so clean up the redundant calls.

(context: I tried to convert HexStr to use span, but this turns out to
be somewhat more involved than I thought, because of the limitation to
pre-c++17 Span lacking iterator-based constructor) . This commit is a
first step which stands on its own though)

Backport of core PR19373.

Test Plan
ninja all check-all

ninja bitcoin-fuzzers
./test/fuzz/test_runner.py <path_to_corpus>

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable