Differential D9135

refactor: Drop unused CBufferedFile::Seek()
ClosedPublic
Actions

Authored by Fabien on Feb 2 2021, 17:11.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC29403dd84c95: refactor: Drop unused CBufferedFile::Seek()

Summary

Backport of core PR19593.

Depends on D9132.

Test Plan

ninja all check-all

ninja bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 2 2021, 17:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2021, 17:11

Fabien requested review of this revision.Feb 2 2021, 17:11

teamcity edited the summary of this revision. (Show Details)Feb 2 2021, 17:12

Harbormaster completed remote builds in B15082: Diff 27476.Feb 2 2021, 17:28

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_bind.py ======

------- Stdout: -------
2021-02-02T17:22:43.520000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139
2021-02-02T17:22:43.520000Z TestFramework (INFO): Check for linux
2021-02-02T17:22:43.561000Z TestFramework (INFO): Check for ipv6
2021-02-02T17:22:43.561000Z TestFramework (INFO): Check for non-loopback interface
2021-02-02T17:22:43.562000Z TestFramework (INFO): Bind test for []
2021-02-02T17:22:44.305000Z TestFramework (INFO): Bind test for []
2021-02-02T17:22:45.039000Z TestFramework (INFO): Bind test for ['[::1]']
2021-02-02T17:22:45.785000Z TestFramework (INFO): Bind test for ['127.0.0.1', '[::1]']
2021-02-02T17:22:46.510000Z TestFramework (INFO): Using interface 172.17.0.2 for testing
2021-02-02T17:22:46.510000Z TestFramework (INFO): Bind test for ['172.17.0.2']
2021-02-02T17:22:46.791000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 124, in main
    self.run_test()
  File "/work/test/functional/rpc_bind.py", line 136, in run_test
    self._run_nonloopback_tests()
  File "/work/test/functional/rpc_bind.py", line 171, in _run_nonloopback_tests
    [(self.non_loopback_ip, self.defaultport)])
  File "/work/test/functional/rpc_bind.py", line 72, in run_bind_test
    assert_equal(set(get_bind_addrs(pid)), set(expected))
  File "/work/test/functional/test_framework/netutil.py", line 87, in get_bind_addrs
    inodes = get_socket_inodes(pid)
  File "/work/test/functional/test_framework/netutil.py", line 37, in get_socket_inodes
    target = os.readlink(os.path.join(base, item))
FileNotFoundError: [Errno 2] No such file or directory: '/proc/7083/fd/17'
2021-02-02T17:22:46.842000Z TestFramework (INFO): Stopping nodes
2021-02-02T17:22:47.045000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139
2021-02-02T17:22:47.045000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139/test_framework.log
2021-02-02T17:22:47.045000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_bind.py