Page MenuHomePhabricator

refactor: Drop unused CBufferedFile::Seek()

Authored by Fabien on Feb 2 2021, 17:11.


Group Reviewers
Restricted Project
rABC29403dd84c95: refactor: Drop unused CBufferedFile::Seek()

Backport of core PR19593.

Depends on D9132.

Test Plan
ninja all check-all

ninja bitcoin-fuzzers

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Feb 2 2021, 17:11

Failed tests logs:

====== Bitcoin ABC functional tests: ======

------- Stdout: -------
2021-02-02T17:22:43.520000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139
2021-02-02T17:22:43.520000Z TestFramework (INFO): Check for linux
2021-02-02T17:22:43.561000Z TestFramework (INFO): Check for ipv6
2021-02-02T17:22:43.561000Z TestFramework (INFO): Check for non-loopback interface
2021-02-02T17:22:43.562000Z TestFramework (INFO): Bind test for []
2021-02-02T17:22:44.305000Z TestFramework (INFO): Bind test for []
2021-02-02T17:22:45.039000Z TestFramework (INFO): Bind test for ['[::1]']
2021-02-02T17:22:45.785000Z TestFramework (INFO): Bind test for ['', '[::1]']
2021-02-02T17:22:46.510000Z TestFramework (INFO): Using interface for testing
2021-02-02T17:22:46.510000Z TestFramework (INFO): Bind test for ['']
2021-02-02T17:22:46.791000Z TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/work/test/functional/test_framework/", line 124, in main
  File "/work/test/functional/", line 136, in run_test
  File "/work/test/functional/", line 171, in _run_nonloopback_tests
    [(self.non_loopback_ip, self.defaultport)])
  File "/work/test/functional/", line 72, in run_bind_test
    assert_equal(set(get_bind_addrs(pid)), set(expected))
  File "/work/test/functional/test_framework/", line 87, in get_bind_addrs
    inodes = get_socket_inodes(pid)
  File "/work/test/functional/test_framework/", line 37, in get_socket_inodes
    target = os.readlink(os.path.join(base, item))
FileNotFoundError: [Errno 2] No such file or directory: '/proc/7083/fd/17'
2021-02-02T17:22:46.842000Z TestFramework (INFO): Stopping nodes
2021-02-02T17:22:47.045000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139
2021-02-02T17:22:47.045000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139/test_framework.log
2021-02-02T17:22:47.045000Z TestFramework (ERROR): Hint: Call /work/test/functional/ '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210202_172241/rpc_bind_139' to consolidate all logs

Each failure log is accessible here:
Bitcoin ABC functional tests:

majcosta added a subscriber: majcosta.

ran locally, test failure is unrelated

This revision is now accepted and ready to land.Feb 3 2021, 05:45
This revision was landed with ongoing or failed builds.Feb 3 2021, 10:38
This revision was automatically updated to reflect the committed changes.