Differential D9142

test: use inventory type constant MSG_CMPCT_BLOCK
ClosedPublic
Actions

Authored by PiRK on Feb 3 2021, 13:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6791b7f377cf: test: use inventory type constant MSG_CMPCT_BLOCK

Summary

Bitcoin ABC already had such a constant, so this just renames it to use
the same as Core and uses it in p2p_compactblocks.py

This is a backport of Core PR18764 [2/3]
https://github.com/bitcoin/bitcoin/pull/18764/commits/b35e1d2471c3d9e0b6cc4b94f4726a7e6ea32206

Depends on D9141

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 3 2021, 13:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2021, 13:57

PiRK requested review of this revision.Feb 3 2021, 13:57

teamcity edited the summary of this revision. (Show Details)Feb 3 2021, 13:57

PiRK added a child revision: D9143: test: explicit imports from test_framework.messages in p2p_invalid_messages.py.Feb 3 2021, 14:04

Fabien accepted this revision.Feb 3 2021, 14:08

This revision is now accepted and ready to land.Feb 3 2021, 14:08

Harbormaster completed remote builds in B15091: Diff 27498.Feb 3 2021, 14:28

Closed by commit rABC6791b7f377cf: test: use inventory type constant MSG_CMPCT_BLOCK (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyFeb 3 2021, 14:29

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6791b7f377cf: test: use inventory type constant MSG_CMPCT_BLOCK.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-get-invalid-block.py

4 lines

p2p_compactblocks.py

9 lines

test_framework/

messages.py

4 lines

Diff 27503

View Options

test/functional/abc-get-invalid-block.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/test_framework/messages.py

test: use inventory type constant MSG_CMPCT_BLOCKClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27503

test/functional/abc-get-invalid-block.py

test/functional/p2p_compactblocks.py

test/functional/test_framework/messages.py

test: use inventory type constant MSG_CMPCT_BLOCK
ClosedPublic
Actions

Revision Contents
Changeset List