Do not bust cached npm-installed dependencies when source files change
ClosedPublic
Actions

Authored by jasonbcox on Feb 3 2021, 21:28.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

Summary

Similar to D9157, this patch reduces cache busts related to npm packages
and improves rebuild time by ~55% (~70 seconds on my machine).

Depends on D9157

Test Plan

docker build --no-cache -t cashtab .

Change a Cashtab source file, then:

docker build -t cashtab .

Sanity check:

docker run -it -p 9000:80 cashtab

Repository

rABC Bitcoin ABC

Branch

cachebust-cashtab-npm

Lint

Lint Passed

Unit

No Test Coverage

Build Status

jasonbcox requested review of this revision.Feb 3 2021, 21:29

majcosta added inline comments.

web/cashtab/Dockerfile
18–20	you can go even further if you want, just `COPY package-lock.json` and `RUN npm ci`

majcosta requested changes to this revision.Feb 3 2021, 21:48

This revision now requires changes to proceed.Feb 3 2021, 21:48

jasonbcox requested review of this revision.Feb 3 2021, 21:58

jasonbcox added inline comments.

web/cashtab/Dockerfile
18–20	`npm ci` still uses `package.json` for reference, as it will error out if `package-lock.json` does not match `package.json` I specifically put `npm ci` into its own diff in case it generates additional discussion on the impact of reproducible builds (see D9159)