Differential D9171

net: improve encapsulation of CNetAddr
ClosedPublic
Actions

Authored by Fabien on Thu, Feb 4, 16:59.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC2184cc687dab: net: improve encapsulation of CNetAddr

Summary

Do not access `CNetAddr::ip` directly from `CService` methods.

This improvement will help later when we change the type of
`CNetAddr::ip` (in the BIP155 implementation).

Backport of core PR19360.

Depends on D9169.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Feb 4, 16:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 4, 16:59

Fabien requested review of this revision.Thu, Feb 4, 16:59

teamcity edited the summary of this revision. (Show Details)Thu, Feb 4, 16:59

Fabien added a child revision: D9172: net: save the network type explicitly in CNetAddr.Thu, Feb 4, 17:05

Harbormaster completed remote builds in B15125: Diff 27558.Thu, Feb 4, 17:17

majcosta accepted this revision.Thu, Feb 4, 22:16

This revision is now accepted and ready to land.Thu, Feb 4, 22:16

Closed by commit rABC2184cc687dab: net: improve encapsulation of CNetAddr (authored by Vasil Dimov <vd@FreeBSD.org>, committed by Fabien). · Explain WhyFri, Feb 5, 17:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2184cc687dab: net: improve encapsulation of CNetAddr.

Revision Contents
Changeset List

Path

Size

src/

netaddress.h

3 lines

netaddress.cpp

10 lines

Diff 27582

View Options

src/netaddress.h