Differential D9183

refactor: Make HexStr take a span
ClosedPublic
Actions

Authored by Fabien on Feb 9 2021, 10:37.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3288ce1b2218: refactor: Make HexStr take a span

Summary

Make HexStr take a span of bytes, instead of an awkward pair of
templated iterators.

Backport of core PR19660.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19660

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15145
Build 30240: Build Diff	build-clang · lint-circular-dependencies · build-debug · build-without-wallet · build-diff · build-clang-tidy
Build 30239: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 9 2021, 10:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2021, 10:37

Fabien requested review of this revision.Feb 9 2021, 10:37

teamcity edited the summary of this revision. (Show Details)Feb 9 2021, 10:37

Fabien added a child revision: D9184: refactor: make EncodeBase{32,64} consume Spans.Feb 9 2021, 10:43

PiRK accepted this revision.Feb 9 2021, 11:35

This revision is now accepted and ready to land.Feb 9 2021, 11:35

Harbormaster completed remote builds in B15145: Diff 27597.Feb 9 2021, 11:57

Closed by commit rABC3288ce1b2218: refactor: Make HexStr take a span (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by Fabien). · Explain WhyFeb 9 2021, 12:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3288ce1b2218: refactor: Make HexStr take a span.

Revision Contents
Changeset List

Path

Size

src/

core_write.cpp

12 lines

net.cpp

6 lines

rpc/

avalanche.cpp

2 lines

rawtransaction.cpp

2 lines

request.cpp

3 lines

script/

descriptor.cpp

4 lines

test/

2 lines

3 lines

41 lines

8 lines

util/

strencodings.h

22 lines

strencodings.cpp

12 lines

wallet/

bdb.cpp

5 lines

rpcdump.cpp

2 lines

rpcwallet.cpp

3 lines

Diff 27597

View Options

src/core_write.cpp

View Options

src/net.cpp

View Options

src/rpc/avalanche.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/request.cpp

View Options

src/script/descriptor.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/settings_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/uint256.cpp

View Options

src/util/strencodings.h

View Options

src/util/strencodings.cpp

View Options

src/wallet/bdb.cpp

View Options

src/wallet/rpcdump.cpp

View Options

refactor: Make HexStr take a spanClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27597

src/core_write.cpp

src/net.cpp

src/rpc/avalanche.cpp

src/rpc/rawtransaction.cpp

src/rpc/request.cpp

src/script/descriptor.cpp

src/test/crypto_tests.cpp

src/test/settings_tests.cpp

src/test/util_tests.cpp

src/uint256.cpp

src/util/strencodings.h

src/util/strencodings.cpp

src/wallet/bdb.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

refactor: Make HexStr take a span
ClosedPublic
Actions

Revision Contents
Changeset List