Differential D9186

util: move HasPrefix() so it can be reused
ClosedPublic
Actions

Authored by Fabien on Feb 9 2021, 12:26.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC7af7f8499288: util: move HasPrefix() so it can be reused

Summary

Move the function `HasPrefix()` from `netaddress.cpp` to `util/string.h`
so it can be reused by `CNetAddr` methods (and possibly others).

Partial backport (1/4) of core PR19845:
https://github.com/bitcoin/bitcoin/pull/19845/commits/d2bb681f96fb327b4c4d5b2b113692ca22fdffbf

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 9 2021, 12:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2021, 12:26

Fabien requested review of this revision.Feb 9 2021, 12:26

teamcity edited the summary of this revision. (Show Details)Feb 9 2021, 12:26

Fabien added a child revision: D9188: net: CNetAddr: add support to (un)serialize as ADDRv2.Feb 9 2021, 12:33

Harbormaster completed remote builds in B15148: Diff 27600.Feb 9 2021, 12:43

majcosta accepted this revision.Feb 9 2021, 15:30

This revision is now accepted and ready to land.Feb 9 2021, 15:30

majcosta added a child revision: D9187: test: move HasReason so it can be reused.Feb 9 2021, 15:32

Closed by commit rABC7af7f8499288: util: move HasPrefix() so it can be reused (authored by Vasil Dimov <vd@FreeBSD.org>, committed by Fabien). · Explain WhyFeb 9 2021, 16:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7af7f8499288: util: move HasPrefix() so it can be reused.

Revision Contents
Changeset List

Path

Size

src/

netaddress.cpp

8 lines

util/

string.h

12 lines

Diff 27616

View Options

src/netaddress.cpp