Paths

Table of Contentst

Differential D9237

cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC()
ClosedPublic
Actions

Authored by PiRK on Feb 17 2021, 14:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC61bb2abbe050: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC()

Summary

This is needed for RPCs that need to be called and handled sequentially, rather
than alone or in a batch.

For example, when fetching the balances for each loaded wallet, -getinfo will
call RPC listwallets, and then, depending on the result, RPC getbalances.

This is a backport of Core PR18594 [1/6]
https://github.com/bitcoin/bitcoin/pull/18594/commits/29f2cbdeb7afdde87d108adf80cffad17d112632

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 17 2021, 14:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 17 2021, 14:35

PiRK requested review of this revision.Feb 17 2021, 14:35

teamcity edited the summary of this revision. (Show Details)Feb 17 2021, 14:35

PiRK added a child revision: D9238: cli: lift -rpcwallet logic up to CommandLineRPC().Feb 17 2021, 14:37

Harbormaster completed remote builds in B15215: Diff 27718.Feb 17 2021, 14:49

majcosta accepted this revision.Feb 17 2021, 18:09

This revision is now accepted and ready to land.Feb 17 2021, 18:09

Closed by commit rABC61bb2abbe050: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC() (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 18 2021, 12:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC61bb2abbe050: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC().

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

123 lines

Diff 27741

src/bitcoin-cli.cpp

Loading...