Page MenuHomePhabricator

[Cashtab] fix css issue with long wallet display names
ClosedPublic

Authored by josephroyking on Wed, Feb 17, 21:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9e5d2722498a: [Cashtab] fix css issue with long wallet display names
Summary

Reduce font size for active wallet name at resolutions where it would overflow. Truncate wallet name in Saved Wallets list if it overflows its divs. Ellipsis truncation approach for SavedWallets lists deemed more robust than highly specific font size resolutions by screen size; displaying the last few characters of a long wallet name is not critical.

Test Plan
cd web/cashtab
npm start

Create a new wallet and rename it with longest possible name, e.g. AAAAAAAAAAAAAAAAAAAAAAA

Using dev console of web browser, test appearance of wallet name at resolutions between 320px and 1280px. Verify either no overflow or overflow handled by ellipsis.

npm test to verify no impact on covered methods; change only impacts app appearance.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien added a subscriber: Fabien.

Tested locally and it works.
Please update the test plan, afaik there is no test coverage for this.

This revision is now accepted and ready to land.Thu, Feb 18, 10:24