Reduce font size for active wallet name at resolutions where it would overflow. Truncate wallet name in Saved Wallets list if it overflows its divs. Ellipsis truncation approach for SavedWallets lists deemed more robust than highly specific font size resolutions by screen size; displaying the last few characters of a long wallet name is not critical.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC9e5d2722498a: [Cashtab] fix css issue with long wallet display names
cd web/cashtab npm start
Create a new wallet and rename it with longest possible name, e.g. AAAAAAAAAAAAAAAAAAAAAAA
Using dev console of web browser, test appearance of wallet name at resolutions between 320px and 1280px. Verify either no overflow or overflow handled by ellipsis.
npm test to verify no impact on covered methods; change only impacts app appearance.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- truncate-address-names
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15222 Build 30381: Build Diff cashtab-tests Build 30380: arc lint + arc unit
Event Timeline
Comment Actions
Tested locally and it works.
Please update the test plan, afaik there is no test coverage for this.