Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf77a8a4d352e: convert all remaining serializations to new style

Summary

This converts all Bitcoin ABC serializations that were not converted by
Core backports.

Test Plan

ninja all check-all

Build an avalanche proof with bitcoin-cli buildavalancheproof ... and verify the result hasn't changed.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 18 2021, 07:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 18 2021, 07:29

PiRK requested review of this revision.Feb 18 2021, 07:29

PiRK added a child revision: D9248: Remove old serialization primitives.Feb 18 2021, 07:31

PiRK edited the test plan for this revision. (Show Details)Feb 18 2021, 07:36

Harbormaster completed remote builds in B15226: Diff 27731.Feb 18 2021, 07:46

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[327/503] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[328/503] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[329/503] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[330/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[331/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[332/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[333/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[334/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[335/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[336/503] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[337/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[338/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[339/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[340/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[341/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[342/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[343/503] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[344/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[345/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[346/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[347/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[348/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[349/503] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[350/503] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[351/503] Linking CXX static library src/libutil.a
[352/503] Linking CXX static library src/librpcclient.a
[353/503] Linking CXX static library src/libbitcoinconsensus.a
[354/503] Linking CXX static library src/libscript.a
[355/503] Linking CXX static library src/libcommon.a
[356/503] Linking CXX shared library src/libbitcoinconsensus.so.0.22.13
[357/503] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[358/503] Linking CXX executable src/bitcoin-cli
[359/503] Linking CXX executable src/bitcoin-tx
[360/503] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[361/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[362/503] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[363/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[364/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[365/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[366/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[367/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[368/503] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[369/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[370/503] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[371/503] Linking CXX static library src/zmq/libzmq.a
[372/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[373/503] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[374/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[375/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[376/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[377/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[378/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[379/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[380/503] Linking CXX static library src/wallet/libwallet.a
[381/503] Linking CXX static library src/wallet/libwallet-tool.a
[382/503] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

getters are required to silence a compiler warning

-Wunused-private-field

annotate two private attributes in avalanche/protocol.h with [[maybe_unused]] to suppress a compiler warning

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[332/503] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[333/503] Linking C executable src/secp256k1/recover-bench
[334/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[335/503] Installing component secp256k1
-- Install configuration: "Debug"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[336/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[337/503] Linking CXX static library src/libbitcoinconsensus.a
[338/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[339/503] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[340/503] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[341/503] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[342/503] Linking C executable src/secp256k1/internal-bench
[343/503] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[344/503] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[345/503] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[346/503] Linking CXX static library src/libscript.a
[347/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[348/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[349/503] Linking CXX static library src/libcommon.a
[350/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[351/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[352/503] Linking CXX shared library src/libbitcoinconsensus.so.0.22.13
[353/503] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[354/503] Linking CXX executable src/bitcoin-cli
[355/503] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[356/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[357/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[358/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[359/503] Linking CXX executable src/bitcoin-tx
[360/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[361/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[362/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[363/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[364/503] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[365/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[366/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[367/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[368/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[369/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[370/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[371/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[372/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[373/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[374/503] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[375/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[376/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[377/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[378/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[379/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[380/503] Linking CXX static library src/wallet/libwallet.a
[381/503] Linking CXX static library src/wallet/libwallet-tool.a
[382/503] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Harbormaster completed remote builds in B15233: Diff 27738.Feb 18 2021, 11:00

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[336/450] Linking C executable src/secp256k1/recover-bench
[337/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[338/450] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
FAILED: src/CMakeFiles/server.dir/init.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/init.cpp.o -MF src/CMakeFiles/server.dir/init.cpp.o.d -o src/CMakeFiles/server.dir/init.cpp.o -c ../../src/init.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/init.cpp:14:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[339/450] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[340/450] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[341/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[342/450] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[343/450] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[344/450] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
FAILED: src/CMakeFiles/server.dir/net_processing.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/net_processing.cpp.o -MF src/CMakeFiles/server.dir/net_processing.cpp.o.d -o src/CMakeFiles/server.dir/net_processing.cpp.o -c ../../src/net_processing.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/net_processing.cpp:9:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[345/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[346/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[347/450] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[348/450] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[349/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[350/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[351/450] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[352/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[353/450] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[354/450] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[355/450] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[356/450] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[357/450] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[358/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[359/450] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[360/450] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/validation.cpp:10:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[332/503] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[333/503] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[334/503] Linking C static library src/secp256k1/libsecp256k1.a
[335/503] Linking CXX static library src/libbitcoinconsensus.a
[336/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[337/503] Linking C executable src/secp256k1/ecmult-bench
[338/503] Linking C executable src/secp256k1/internal-bench
[339/503] Linking C executable src/secp256k1/sign-bench
[340/503] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[341/503] Linking C executable src/secp256k1/verify-bench
[342/503] Linking C executable src/secp256k1/recover-bench
[343/503] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[344/503] Linking CXX static library src/libscript.a
[345/503] Linking CXX static library src/libcommon.a
[346/503] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[347/503] Linking CXX shared library src/libbitcoinconsensus.so.0.22.13
[348/503] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[349/503] Linking CXX executable src/bitcoin-cli
[350/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[351/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[352/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[353/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[354/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[355/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[356/503] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[357/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[358/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[359/503] Linking CXX executable src/bitcoin-tx
[360/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[361/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[362/503] Linking CXX static library src/zmq/libzmq.a
[363/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[364/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[365/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[366/503] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[367/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[368/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[369/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[370/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[371/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[372/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[373/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[374/503] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[375/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[376/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[377/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[378/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[379/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[380/503] Linking CXX static library src/wallet/libwallet.a
[381/503] Linking CXX static library src/wallet/libwallet-tool.a
[382/503] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

replace a SER_READ with SER_WRITE (seeder/db.h l234)

I missed the negation in else if (!ser_action.ForRead())

Harbormaster completed remote builds in B15235: Diff 27740.Feb 18 2021, 11:27

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/avalanche/processor.cpp.o -MF src/CMakeFiles/server.dir/avalanche/processor.cpp.o.d -o src/CMakeFiles/server.dir/avalanche/processor.cpp.o -c ../../src/avalanche/processor.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/avalanche/processor.cpp:5:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[379/503] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/avalanche.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/rpc/avalanche.cpp.o -MF src/CMakeFiles/server.dir/rpc/avalanche.cpp.o.d -o src/CMakeFiles/server.dir/rpc/avalanche.cpp.o -c ../../src/rpc/avalanche.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/rpc/avalanche.cpp:6:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[380/503] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
FAILED: src/CMakeFiles/server.dir/net_processing.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/net_processing.cpp.o -MF src/CMakeFiles/server.dir/net_processing.cpp.o.d -o src/CMakeFiles/server.dir/net_processing.cpp.o -c ../../src/net_processing.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/net_processing.cpp:9:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[381/503] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
FAILED: src/CMakeFiles/server.dir/init.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/init.cpp.o -MF src/CMakeFiles/server.dir/init.cpp.o.d -o src/CMakeFiles/server.dir/init.cpp.o -c ../../src/init.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/init.cpp:14:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[382/503] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/validation.cpp:10:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/validation.cpp:10:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[335/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[336/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[337/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[338/503] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[339/503] Linking CXX static library src/libbitcoinconsensus.a
[340/503] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[341/503] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[342/503] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[343/503] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[344/503] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[345/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[346/503] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[347/503] Linking CXX static library src/libscript.a
[348/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[349/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[350/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[351/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[352/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[353/503] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[354/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[355/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[356/503] Linking CXX static library src/libcommon.a
[357/503] Linking CXX shared library src/libbitcoinconsensus.so.0.22.13
[358/503] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[359/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[360/503] Linking CXX executable src/bitcoin-cli
[361/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[362/503] Linking CXX executable src/bitcoin-tx
[363/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[364/503] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[365/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[366/503] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[367/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[368/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[369/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[370/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[371/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[372/503] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[373/503] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[374/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[375/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[376/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[377/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[378/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[379/503] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[380/503] Linking CXX static library src/wallet/libwallet.a
[381/503] Linking CXX static library src/wallet/libwallet-tool.a
[382/503] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/net_processing.cpp:9:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
[323/450] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[324/450] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[325/450] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[326/450] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[327/450] Linking C static library src/secp256k1/libsecp256k1.a
[328/450] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[329/450] Linking C executable src/secp256k1/ecmult-bench
[330/450] Linking C executable src/secp256k1/internal-bench
[331/450] Linking C executable src/secp256k1/sign-bench
[332/450] Linking C executable src/secp256k1/verify-bench
[333/450] Linking CXX static library src/libcommon.a
[334/450] Linking C executable src/secp256k1/recover-bench
[335/450] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[336/450] Linking CXX static library src/libscript.a
[337/450] Linking CXX static library src/libbitcoinconsensus.a
[338/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[339/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[340/450] Linking CXX shared library src/libbitcoinconsensus.so.0.22.13
[341/450] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[342/450] Linking CXX executable src/bitcoin-cli
[343/450] Linking CXX static library src/zmq/libzmq.a
[344/450] Linking CXX executable src/bitcoin-tx
[345/450] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[346/450] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[347/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[348/450] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[349/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[350/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[351/450] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[352/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[353/450] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[354/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[355/450] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[356/450] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[357/450] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[358/450] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[359/450] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[360/450] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wformat-security -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
In file included from ../../src/./avalanche/processor.h:9,
                 from ../../src/validation.cpp:10:
../../src/./avalanche/protocol.h:54:31: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] uint64_t round;
                               ^~~~~
../../src/./avalanche/protocol.h:69:46: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
     [[maybe_unused]] std::array<uint8_t, 64> sig;
                                              ^~~
cc1plus: all warnings being treated as errors
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

remove maybe_unused which does not work for GCC with attributes, define two getters instead

Harbormaster completed remote builds in B15236: Diff 27747.Feb 18 2021, 13:43

Fabien requested changes to this revision.Feb 19 2021, 19:50

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/protocol.h
61 ↗	(On Diff #27747)	const
76 ↗	(On Diff #27747)	const
78 ↗	(On Diff #27747)	I think you can remove this comment that brings no value
src/seeder/db.h
219 ↗	(On Diff #27738)	Should be SER_WRITE

This revision now requires changes to proceed.Feb 19 2021, 19:50

nvm last comment, was an old uncommited one

remove "// serialization support" comments and mark getters as const

Harbormaster completed remote builds in B15242: Diff 27755.Feb 22 2021, 07:37

Fabien accepted this revision.Feb 22 2021, 08:47

This revision is now accepted and ready to land.Feb 22 2021, 08:47

Closed by commit rABCf77a8a4d352e: convert all remaining serializations to new style (authored by PiRK). · Explain WhyFeb 22 2021, 10:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf77a8a4d352e: convert all remaining serializations to new style.

convert all remaining serializations to new style
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 27760

src/amount.h

src/avalanche/delegation.h

src/avalanche/processor.cpp

src/avalanche/proof.h

src/avalanche/protocol.h

src/blockstatus.h

src/feerate.h

src/seeder/db.h

convert all remaining serializations to new styleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27760

src/amount.h

src/avalanche/delegation.h

src/avalanche/processor.cpp

src/avalanche/proof.h

src/avalanche/protocol.h

src/blockstatus.h

src/feerate.h

src/seeder/db.h

convert all remaining serializations to new style
ClosedPublic
Actions

Revision Contents
Changeset List