Page MenuHomePhabricator

qt: Fix shutdown when waitfor* cmds are called from RPC console
ClosedPublic

Authored by PiRK on Feb 23 2021, 16:16.

Details

Summary

This is a backport of core#18452

Test Plan

bitcoin-qt -server=1

In the RPC console, type waitforblockheight XXXXXX with XXXXXXX a future block height, then close the application. Make sure it does not hang.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Feb 23 2021, 16:16

Tail of the build log:

[380/436] bitcoin: testing sync_tests
[381/436] bitcoin: testing torcontrol_tests
[382/436] bitcoin: testing sigencoding_tests
[383/436] Running utility command for check-bitcoin-bip32_tests
[384/436] Running utility command for check-bitcoin-wallet_crypto_tests
[385/436] Running utility command for check-bitcoin-sync_tests
[386/436] Running utility command for check-bitcoin-torcontrol_tests
[387/436] Running utility command for check-bitcoin-sigencoding_tests
[388/436] bitcoin: testing scriptpubkeyman_tests
[389/436] bitcoin: testing timedata_tests
[390/436] Running utility command for check-bitcoin-scriptpubkeyman_tests
[391/436] Running utility command for check-bitcoin-timedata_tests
[392/436] bitcoin: testing streams_tests
[393/436] Running utility command for check-bitcoin-streams_tests
[394/436] bitcoin: testing undo_tests
[395/436] bitcoin: testing uint256_tests
[396/436] Running utility command for check-bitcoin-undo_tests
[397/436] Running utility command for check-bitcoin-uint256_tests
[398/436] bitcoin: testing blockcheck_tests
[399/436] Running utility command for check-bitcoin-blockcheck_tests
[400/436] bitcoin: testing radix_tests
[401/436] bitcoin: testing script_standard_tests
[402/436] Running utility command for check-bitcoin-radix_tests
[403/436] bitcoin: testing schnorr_tests
[404/436] Running utility command for check-bitcoin-script_standard_tests
[405/436] Running utility command for check-bitcoin-schnorr_tests
[406/436] bitcoin: testing blockstatus_tests
[407/436] Running utility command for check-bitcoin-blockstatus_tests
[408/436] bitcoin: testing cuckoocache_tests
[409/436] bitcoin: testing cashaddr_tests
[410/436] Running utility command for check-bitcoin-cuckoocache_tests
[411/436] bitcoin: testing getarg_tests
[412/436] Running utility command for check-bitcoin-cashaddr_tests
[413/436] bitcoin: testing versionbits_tests
[414/436] Running utility command for check-bitcoin-getarg_tests
[415/436] bitcoin: testing validation_tests
[416/436] Running utility command for check-bitcoin-versionbits_tests
[417/436] bitcoin: testing crypto_tests
[418/436] Running utility command for check-bitcoin-crypto_tests
[419/436] bitcoin: testing script_tests
[420/436] bitcoin: testing skiplist_tests
[421/436] Running utility command for check-bitcoin-validation_tests
[422/436] Running utility command for check-bitcoin-skiplist_tests
[423/436] bitcoin: testing coinselector_tests
FAILED: src/test/CMakeFiles/check-bitcoin-coinselector_tests 
cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-coinselector_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=coinselector_tests --logger=HRF,message:JUNIT,message,bitcoin-coinselector_tests.xml --catch_system_errors=no
Segmentation fault (core dumped)
[424/436] Running utility command for check-bitcoin-script_tests
[425/436] bitcoin: testing wallet_tests
[426/436] Running utility command for check-bitcoin-wallet_tests
[427/436] bitcoin: testing validation_block_tests
[428/436] Running utility command for check-bitcoin-validation_block_tests
[429/436] bitcoin: testing op_reversebytes_tests
[430/436] Running utility command for check-bitcoin-op_reversebytes_tests
[431/436] bitcoin: testing transaction_tests
[432/436] Running utility command for check-bitcoin-transaction_tests
[433/436] bitcoin: testing coins_tests
[434/436] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
This revision is now accepted and ready to land.Feb 23 2021, 17:14
This revision was landed with ongoing or failed builds.Feb 24 2021, 07:19
This revision was automatically updated to reflect the committed changes.