Page MenuHomePhabricator

[Cashtab] Improve nav buttons
ClosedPublic

Authored by josephroyking on Feb 26 2021, 22:17.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCe968c2af645d: [Cashtab] Improve nav buttons
Summary

Reported issue that the nav buttons in bottom footer are glitchy. The responsive click area is not consistent with the cursor:hover display. This is because they were implemented as TabPanes in antd. This diff removes all Tab and TabPane components + associated css over-rides and replaces with button components, which have a responsive click area that's easier to control.

Test Plan

This is a pure css change. npm start and verify that buttons look okay. Click between them. Confirm functional and no "misclick" issues as with current app (where cursor appears as pointer but does not activate button). npm test to confirm no broken unit tests.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable