Page MenuHomePhabricator
Differential D9302

[LINTER] Add mypy to the CI dependencies and exclude the contrib dir
ClosedPublic
Actions

Authored by Fabien on Mar 5 2021, 10:26.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC316527a895f6: [LINTER] Add mypy to the CI dependencies and exclude the contrib dir
Summary

This will unbreak arc lint --everything and the land bot. Contrib
subfolders can be fixed and included in later diffs.
Also added a exclusion for sys.getwindowsversion() which is only
available on windows.

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_mypy_issues
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15322
Build 30573: Build Diffbuild-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 30572: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 5 2021, 10:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2021, 10:26
Fabien requested review of this revision.Mar 5 2021, 10:26
PiRK accepted this revision.Mar 5 2021, 10:31
This revision is now accepted and ready to land.Mar 5 2021, 10:31
This revision was landed with ongoing or failed builds.Mar 5 2021, 10:44
Closed by commit rABC316527a895f6: [LINTER] Add mypy to the CI dependencies and exclude the contrib dir (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC316527a895f6: [LINTER] Add mypy to the CI dependencies and exclude the contrib dir.
Harbormaster completed remote builds in B15322: Diff 27887.Mar 5 2021, 10:56

Revision Contents
Changeset List

PathSize
1 line
contrib/
utils/
1 line
test/
functional/
2 lines

Diff 27887

View Options

.arclint

Loading...
View Options

contrib/utils/install-dependencies.sh

Loading...
View Options

test/functional/test_runner.py

Loading...