Page MenuHomePhabricator

[avalanche] add an inventory type and a message for proofs
ClosedPublic

Authored by PiRK on Tue, Mar 30, 14:15.

Details

Summary

This diff carves out an uncontroversial part of D9327: the definition
of a net message and an inventory type that can be used to exchange
avalanche proofs over the network.

A basic proof object and a msg_avahello are also added to the test
framework, with a simple serialization round trip unit test.
The AvalancheProof object will be later expanded (the code already
exists in abandoned diff D9341)

Test Plan

ninja && ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Tue, Mar 30, 14:15
deadalnix requested changes to this revision.Tue, Mar 30, 16:15
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/protocol.h
504 ↗(On Diff #28047)

Use a temp number during dev. I used 0x1f000001 when I was trying to make this work.

504 ↗(On Diff #28047)

Also, MSG_AVA_PROOF because you use avaproof elsewhere.

This revision now requires changes to proceed.Tue, Mar 30, 16:15

rename inventory type to MSG_AVA_PROOF and use a temporary inventory code

This revision is now accepted and ready to land.Thu, Apr 1, 12:23