[avalanche] implement a proof relay struct
AbandonedPublic
Actions

Authored by PiRK on Apr 6 2021, 16:29.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

A peer has a set of proofs that we queue to share them with him and a filter of known proofs.
This struct is similar to the one used for transactions.

We initialize it for all node except block-relay nodes.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

proofrelay

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15574
Build 31067: Build Diff	lint-circular-dependencies · build-debug · build-diff · build-without-wallet · build-clang-tidy · build-clang
Build 31066: arc lint + arc unit

Event Timeline

PiRK created this revision.Apr 6 2021, 16:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2021, 16:29

PiRK requested review of this revision.Apr 6 2021, 16:29

PiRK planned changes to this revision.

Harbormaster completed remote builds in B15445: Diff 28074.Apr 6 2021, 16:44

PiRK added a child revision: D9399: [avalanche] start relaying proof inventories.Apr 13 2021, 15:13

rebase.
Simplify initialization of struct: the plan is to relay proof inventories to everyone, so the struct can be initialized in the constructor, we don't need to wait for service flags.

PiRK edited the summary of this revision. (Show Details)Apr 26 2021, 09:40

Harbormaster completed remote builds in B15574: Diff 28266.Apr 26 2021, 09:46

The approach looks sensible, but there are no test for anything. It seems like this does too little to constitute a unit.

src/net.cpp
3007	That doesn't sound like something you want to do unconditionally on all nodes.

I conclude from the lack of answer that there is actually no reason to initialize the struct where it is.

This revision now requires changes to proceed.Apr 29 2021, 11:57

PiRK added inline comments.Apr 29 2021, 12:13

src/net.cpp
3007	That doesn't sound like something you want to do unconditionally on all nodes. The way I see the problem, we either need to make nodes signal with a service flag that they are willing to relay proofs, or we need to relay proofs to all nodes unconditionally.