Differential D9373

[SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t
ClosedPublic
Actions

Authored by Fabien on Apr 8 2021, 07:36.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC543f9c584f75: [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t

Summary

As identified in #829 and #833. Fixes #829.

Since we touch this anyway, this commit additionally makes the
identifiers in the benchmark files a little bit more consistent.

Typedef (u)int128_t only when they're not provided by the compiler

Backport of secp256k1#835

Test Plan

ninja check-secp256k1 bench-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR835

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15456
Build 30833: Build Diff	lint-circular-dependencies · build-without-wallet · build-secp256k1-bench · build-secp256k1-java · build-clang-tidy · build-diff · build-secp256k1 · build-clang · build-debug
Build 30832: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 8 2021, 07:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2021, 07:36

Fabien requested review of this revision.Apr 8 2021, 07:36

teamcity edited the summary of this revision. (Show Details)Apr 8 2021, 07:36

Harbormaster completed remote builds in B15456: Diff 28086.Apr 8 2021, 07:48

deadalnix accepted this revision.Apr 8 2021, 13:03

This revision is now accepted and ready to land.Apr 8 2021, 13:03

Closed by commit rABC543f9c584f75: [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t (authored by Tim Ruffing <crypto@timruffing.de>, committed by Fabien). · Explain WhyApr 8 2021, 13:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC543f9c584f75: [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

10 lines

22 lines

modules/

extrakeys/

2 lines

schnorrsig/

2 lines

2 lines

12 lines

10 lines

Diff 28086

src/secp256k1/src/bench_sign.c

Loading...

src/secp256k1/src/bench_verify.c

Loading...

src/secp256k1/src/modules/extrakeys/main_impl.h

Loading...

src/secp256k1/src/modules/schnorrsig/main_impl.h

Loading...

src/secp256k1/src/secp256k1.c

Loading...

src/secp256k1/src/tests.c

Loading...

src/secp256k1/src/util.h

Loading...