Differential D9376

[SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
ClosedPublic
Actions

Authored by Fabien on Apr 8 2021, 08:49.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb9aaa07a18ed: [SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation

Summary

Backport of secp256k1#854

Did the same for the schnorr module.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 8 2021, 08:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2021, 08:49

Fabien requested review of this revision.Apr 8 2021, 08:49

teamcity edited the summary of this revision. (Show Details)Apr 8 2021, 08:49

Harbormaster completed remote builds in B15459: Diff 28091.Apr 8 2021, 09:07

PiRK accepted this revision.Apr 8 2021, 11:51

This revision is now accepted and ready to land.Apr 8 2021, 11:51

Closed by commit rABCb9aaa07a18ed: [SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by Fabien). · Explain WhyApr 8 2021, 13:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb9aaa07a18ed: [SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

include/

secp256k1.h

45 lines

secp256k1_recovery.h

24 lines

secp256k1_schnorr.h

31 lines

src/

modules/

recovery/

main_impl.h

12 lines

schnorr/

main_impl.h

12 lines

secp256k1.c

52 lines

Diff 28103

View Options

src/secp256k1/include/secp256k1.h

View Options

src/secp256k1/include/secp256k1_recovery.h

View Options

src/secp256k1/include/secp256k1_schnorr.h

View Options

src/secp256k1/src/modules/recovery/main_impl.h

View Options

src/secp256k1/src/modules/schnorr/main_impl.h

View Options

src/secp256k1/src/secp256k1.c

[SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28103

src/secp256k1/include/secp256k1.h

src/secp256k1/include/secp256k1_recovery.h

src/secp256k1/include/secp256k1_schnorr.h

src/secp256k1/src/modules/recovery/main_impl.h

src/secp256k1/src/modules/schnorr/main_impl.h

src/secp256k1/src/secp256k1.c

[SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation
ClosedPublic
Actions

Revision Contents
Changeset List