Page MenuHomePhabricator

[refactor] extract function for past activation tests
ClosedPublic

Authored by majcosta on Fri, Apr 23, 16:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCd7f5657808e3: [refactor] extract function for past activation tests
Summary

height-based past activation tests use identical code; extract it to a function and call it passing the IsXEnabled function and height as parameters

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix requested changes to this revision.Sat, Apr 24, 00:04
deadalnix added a subscriber: deadalnix.

Please edit the diff's title and description, right now they are not even proper sentences.

src/test/activation_tests.cpp
43 ↗(On Diff #28265)

Extra new line.

This revision now requires changes to proceed.Sat, Apr 24, 00:04
majcosta retitled this revision from [refactor] test past activations by height at the same place to [refactor] extract function for past activation tests.
majcosta edited the summary of this revision. (Show Details)
majcosta marked an inline comment as done.
majcosta added inline comments.
src/test/activation_tests.cpp
43 ↗(On Diff #28265)

that line was removed by arc lint, should we change it?

majcosta edited the summary of this revision. (Show Details)
deadalnix requested changes to this revision.Mon, Apr 26, 20:57
deadalnix added inline comments.
src/test/activation_tests.cpp
43 ↗(On Diff #28265)

arc lint doesn't remove new lines between functions.

This revision now requires changes to proceed.Mon, Apr 26, 20:57
majcosta marked an inline comment as done.

corrected missing line between functions, made testPastActivation static

This revision is now accepted and ready to land.Tue, Apr 27, 15:17