Page MenuHomePhabricator

Fix proof id computation in the test framework
ClosedPublic

Authored by Fabien on Fri, Apr 30, 13:39.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC1b49fb9d35b8: Fix proof id computation in the test framework
Summary

I found the python proofid computation didn't match the node during
testing. There is currently no code using it, but it is worth fixing to
avoid somebody else from getting trapped in the future by this bug.

I added a proofid check to the messages.py unit test, and since I had to
deserialize the test proof I also added checks that will help
documenting the serialized proof content.

Test Plan
pytest ./test/functional/test_framework/messages.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable