HomePhabricator

Fix proof id computation in the test framework

Description

Fix proof id computation in the test framework

Summary:
I found the python proofid computation didn't match the node during
testing. There is currently no code using it, but it is worth fixing to
avoid somebody else from getting trapped in the future by this bug.

I added a proofid check to the messages.py unit test, and since I had to
deserialize the test proof I also added checks that will help
documenting the serialized proof content.

Test Plan:

pytest ./test/functional/test_framework/messages.py

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9461

Details

Provenance
FabienAuthored on Fri, Apr 30, 13:36
FabienPushed on Fri, Apr 30, 18:46
Reviewer
Restricted Project
Differential Revision
D9461: Fix proof id computation in the test framework
Parents
rABC216f0b3f476f: Ensure Axion can be reactivated consistently in abc_mining_basic
Branches
Unknown
Tags
Unknown