Page MenuHomePhabricator
Differential D9473

[website] remove exchanges that don't have withdrawals and deposits enabled
ClosedPublic
Actions

Authored by Mengerian on May 4 2021, 18:39.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCWEB6c07bbb0e640: [website] remove exchanges that don't have withdrawals and deposits enabled
Summary

As far as I know, this leaves only Coinex, STEX and Upbit for now.
The others have had plenty of time to re-enable deposits and withdrawals,
so we should remove them for now. We can re-add if/when they re-enable.

Test Plan

Built and locally and looked at the page and tested links.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
remove-exchanges
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15644
Build 31200: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 4 2021, 18:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2021, 18:39
Mengerian requested review of this revision.May 4 2021, 18:39
Harbormaster completed remote builds in B15629: Diff 28346.May 4 2021, 18:39
majcosta accepted this revision.May 4 2021, 19:12
This revision is now accepted and ready to land.May 4 2021, 19:12
Mengerian planned changes to this revision.May 4 2021, 19:12

We'll reach out another time to offer help to the exchanges before landing this.

Mengerian updated this revision to Diff 28364.May 5 2021, 23:21

Keep STEX, they have working withdrawal/deposit

This revision is now accepted and ready to land.May 5 2021, 23:21
Harbormaster completed remote builds in B15643: Diff 28364.May 5 2021, 23:21
Mengerian updated this revision to Diff 28365.May 5 2021, 23:25
Mengerian edited the summary of this revision. (Show Details)
Mengerian removed a reviewer: majcosta.

Update Diff summary

This revision now requires review to proceed.May 5 2021, 23:25
Harbormaster completed remote builds in B15644: Diff 28365.May 5 2021, 23:25
Mengerian planned changes to this revision.May 5 2021, 23:27
Mengerian requested review of this revision.May 9 2021, 22:11

We may as well land this now IMO.

Sounds like some exchanges are waiting until after May 15th to reopen, but we can add them back then as needed.

majcosta accepted this revision.May 9 2021, 22:39
This revision is now accepted and ready to land.May 9 2021, 22:39
Closed by commit rABCWEB6c07bbb0e640: [website] remove exchanges that don't have withdrawals and deposits enabled (authored by Mengerian). · Explain WhyMay 10 2021, 00:38
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABCWEB6c07bbb0e640: [website] remove exchanges that don't have withdrawals and deposits enabled.

Revision Contents
Changeset List

Diff 28365

View Options

bcha.html

Loading...
View Options

img/Bithumb_logo.png

Loading...
View Options

img/binance.png

Loading...
View Options

img/huobi.png

Loading...
View Options

img/kucoin.svg

Loading...
View Options

img/mxc_logo.png

Loading...
View Options

img/okex_logo.png

Loading...