Page MenuHomePhabricator

[Cashtab] Patch validation bug on settings page
ClosedPublic

Authored by bytesofman on May 5 2021, 17:52.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCad083d3fedb7: [Cashtab] Patch validation bug on settings page
Summary

Cashtab app shows validation errors in modals to delete wallet and to rename wallet without any user input. This diff ensures that validation errors only appear after invalid input is entered.

Mnemonic validation not showing properly. Resolved by matching same format used for delete and rename wallet validation.

Test Plan
  1. npm start
  1. try to rename a wallet, observe validation error does not appear unless an invalid name is typed (or blank input is submitted)
  1. try to delete a wallet, observe validation error does not appear unless input is typed incorrectly (or blank input is submitted)
  1. Copy paste a mnemonic seed into "Import Wallet' mnemonic field. Change 1 letter and observe validation error.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable