HomePhabricator

[Cashtab] Patch validation bug on settings page

Description

[Cashtab] Patch validation bug on settings page

Summary:
Cashtab app shows validation errors in modals to delete wallet and to rename wallet without any user input. This diff ensures that validation errors only appear after invalid input is entered.

Mnemonic validation not showing properly. Resolved by matching same format used for delete and rename wallet validation.

Test Plan:

  1. npm start
  1. try to rename a wallet, observe validation error does not appear unless an invalid name is typed (or blank input is submitted)
  1. try to delete a wallet, observe validation error does not appear unless input is typed incorrectly (or blank input is submitted)
  1. Copy paste a mnemonic seed into "Import Wallet' mnemonic field. Change 1 letter and observe validation error.

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9479

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on May 5 2021, 17:43
bytesofmanPushed on May 5 2021, 18:35
Reviewer
Restricted Project
Differential Revision
D9479: [Cashtab] Patch validation bug on settings page
Parents
rABC1377a4f39fc1: [backport#20016] uint256: 1 is a constant
Branches
Unknown
Tags
Unknown