Page MenuHomePhabricator
Differential D955

Move zmq test skipping logic into individual test case.
ClosedPublic
Actions

Authored by deadalnix on Jan 15 2018, 00:33.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGda6cf6bddf91: Move zmq test skipping logic into individual test case.
rABCda6cf6bddf91: Move zmq test skipping logic into individual test case.
Summary

This commit uses the new skip test funcationality added in
232b6665bc3e5b134821dc7584968fb439fd5f44 to skip the zmq tests if the
python zmq module is not available or if bitcoind has been built without
zmq support.

This removes the zmq-specific logic from test_runner.py. In general it's
better if test_runner.py has no knowledge of special cases for
individual tests and is a general purpose test runner.

Backport core's PR10097 and PR10307

Test Plan
./test/functional/test_runner.py zmq_test.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 15 2018, 00:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2018, 00:33
schancel accepted this revision.Jan 15 2018, 06:06
This revision is now accepted and ready to land.Jan 15 2018, 06:06
Closed by commit rABCda6cf6bddf91: Move zmq test skipping logic into individual test case. (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyJan 15 2018, 11:31
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
2 lines
34 lines
29 lines

Diff 2509

View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/zmq_test.py

Loading...