Page MenuHomePhabricator
Differential D9575

[test] Remove final references to mininode
ClosedPublic
Actions

Authored by PiRK on May 24 2021, 09:10.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCa11aba33476e: [test] Remove final references to mininode
Summary

This concludes backport of core#19760 [4/4]
https://github.com/bitcoin/bitcoin/pull/19760/commits/d5800da5199527a366024bc80cad7fcca17d5c4a

There is a minor change to a comment that is missing in p2p_permissions.py because of a new test that is not yet backported.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 24 2021, 09:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2021, 09:10
PiRK requested review of this revision.May 24 2021, 09:10
teamcity edited the summary of this revision. (Show Details)May 24 2021, 09:10
PiRK added inline comments.May 24 2021, 09:12
test/functional/example_test.py
179 ↗(On Diff #28582)

This change is not part of the pull request, but it matches the core codebase, and it is a common python idiom when running a loop without using the index.

Harbormaster completed remote builds in B15792: Diff 28582.May 24 2021, 09:35
majcosta accepted this revision.May 24 2021, 17:01
This revision is now accepted and ready to land.May 24 2021, 17:01
Closed by commit rABCa11aba33476e: [test] Remove final references to mininode (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyMay 24 2021, 19:18
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa11aba33476e: [test] Remove final references to mininode.

Revision Contents
Changeset List

PathSize
doc/
4 lines
test/
functional/
4 lines
2 lines
test_framework/
2 lines
12 lines
6 lines

Diff 28587

View Options

doc/functional-tests.md

Loading...
View Options

test/functional/example_test.py

Loading...
View Options

test/functional/feature_block.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...
View Options

test/functional/test_framework/p2p.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...