Differential D9579

Pick better names for the tests in p2p_tx_download.py
ClosedPublic
Actions

Authored by Fabien on May 25 2021, 12:37.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCafee8d25b82e: Pick better names for the tests in p2p_tx_download.py

Summary

Now that there is a test context that can be used with transactions or
proof, rename the variables, functions and comments to reflect this. The
last step is to rename the file. There is no change in behavior.

Depends on D9578.

Test Plan

./test/functional/test_runner.py p2p_tx_download

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.May 25 2021, 12:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2021, 12:37

Fabien requested review of this revision.May 25 2021, 12:37

Fabien added a child revision: D9580: Rename p2p_tx_download to p2p_inv_download.

Harbormaster completed remote builds in B15799: Diff 28594.May 25 2021, 12:57

PiRK accepted this revision.May 25 2021, 13:50

This revision is now accepted and ready to land.May 25 2021, 13:50

Closed by commit rABCafee8d25b82e: Pick better names for the tests in p2p_tx_download.py (authored by Fabien). · Explain WhyMay 25 2021, 18:47

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCafee8d25b82e: Pick better names for the tests in p2p_tx_download.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_tx_download.py

57 lines

Diff 28605

View Options

test/functional/p2p_tx_download.py

Pick better names for the tests in p2p_tx_download.pyClosedPublicActions