RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME
ClosedPublic
Actions

Authored by PiRK on Jun 1 2021, 14:23.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rABCcbb9aa019131: RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME

Summary

This is a backport of core#19282

Test Plan

src/bitcoin-cli help generatetoaddress

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 1 2021, 14:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2021, 14:23

PiRK requested review of this revision.Jun 1 2021, 14:23

teamcity edited the summary of this revision. (Show Details)Jun 1 2021, 14:23

Harbormaster completed remote builds in B15865: Diff 28695.Jun 1 2021, 14:32

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[0m[0;32mwallet_importdescriptors.py                      | ✓ Passed  | 7 s
[0m[0;32mwallet_importmulti.py                            | ✓ Passed  | 6 s
[0m[0;32mwallet_importprunedfunds.py                      | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                                | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                          | ✓ Passed  | 4 s
[0m[0;32mwallet_labels.py                                 | ✓ Passed  | 2 s
[0m[0;32mwallet_listreceivedby.py                         | ✓ Passed  | 47 s
[0m[0;32mwallet_listsinceblock.py                         | ✓ Passed  | 6 s
[0m[0;32mwallet_listtransactions.py                       | ✓ Passed  | 10 s
[0m[0;32mwallet_multiwallet.py                            | ✓ Passed  | 16 s
[0m[0;32mwallet_multiwallet.py --usecli                   | ✓ Passed  | 18 s
[0m[0;32mwallet_reorgsrestore.py                          | ✓ Passed  | 5 s
[0m[0;32mwallet_resendwallettransactions.py               | ✓ Passed  | 9 s
[0m[0;32mwallet_txn_clone.py                              | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_clone.py --mineblock                  | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py                        | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py --mineblock            | ✓ Passed  | 4 s
[0m[0;32mwallet_watchonly.py                              | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli                     | ✓ Passed  | 2 s
[0m[0;32mwallet_zapwallettxes.py                          | ✓ Passed  | 7 s
[0m[1m
ALL                                              | ✓ Passed  | 1196 s (accumulated) 
[0mRuntime: 240 s

----------------------------------------------------------------------
Ran 5 tests in 0.023s

OK

[171/453] Running avalanche test suite
PASSED: avalanche test suite
[194/453] Running seeder test suite
PASSED: seeder test suite
[195/453] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.008s

OK
[196/453] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[353/453] bitcoin: testing wallet_tests
FAILED: src/test/CMakeFiles/check-bitcoin-wallet_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-wallet_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=wallet_tests --logger=HRF,message:JUNIT,message,bitcoin-wallet_tests.xml --catch_system_errors=no
pure virtual method called
terminate called without an active exception
Aborted (core dumped)
[424/453] Running pow test suite
PASSED: pow test suite
[437/453] Running secp256k1 test suite
PASSED: secp256k1 test suite
[446/453] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[450/453] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1