Paths

Table of Contentst

Differential D9620

scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase
ClosedPublic
Actions

Authored by PiRK on Jun 1 2021, 15:58.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa6336823cdd4: scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase

Summary

-BEGIN VERIFY SCRIPT-
sed -i -e 's/WalletDatabase::Create(/CreateWalletDatabase(/g' `git grep -l "WalletDatabase::Create("`
sed -i -e 's/WalletDatabase::CreateDummy(/CreateDummyWalletDatabase(/g' `git grep -l "WalletDatabase::CreateDummy("`
sed -i -e 's/WalletDatabase::CreateMock(/CreateMockWalletDatabase(/g' `git grep -l "WalletDatabase::CreateMock("`
arc lint
-END VERIFY SCRIPT-

This is a partial backport of core#19310 [2/3]
Can be compared with https://github.com/bitcoin/bitcoin/pull/19310/commits/d6045d0ac615b5984b72e83cb25aa8a245a177a0

Backport note: I ran the script rather than cherry-picking the commit.

Depends on D9619

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 1 2021, 15:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2021, 15:58

PiRK requested review of this revision.Jun 1 2021, 15:58

teamcity edited the summary of this revision. (Show Details)Jun 1 2021, 15:58

PiRK edited the summary of this revision. (Show Details)Jun 1 2021, 15:58

PiRK added a parent revision: D9619: Add Create*WalletDatabase functions.

Harbormaster completed remote builds in B15872: Diff 28702.Jun 1 2021, 16:16

deadalnix accepted this revision.Jun 1 2021, 20:13

This revision is now accepted and ready to land.Jun 1 2021, 20:13

Closed by commit rABCa6336823cdd4: scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase (authored by PiRK). · Explain WhyJun 2 2021, 06:12

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa6336823cdd4: scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase.

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

6 lines

wallet_balance.cpp

2 lines

qt/

test/

addressbooktests.cpp

2 lines

wallettests.cpp

2 lines

wallet/

3 lines

test/

coinselector_tests.cpp

6 lines

ismine_tests.cpp

20 lines

scriptpubkeyman_tests.cpp

3 lines

wallet_test_fixture.cpp

2 lines

wallet_tests.cpp

21 lines

walletdb_tests.cpp

2 lines

7 lines

6 lines

Diff 28711

src/bench/coin_selection.cpp

Loading...

src/bench/wallet_balance.cpp

Loading...

src/qt/test/addressbooktests.cpp

Loading...

src/qt/test/wallettests.cpp

Loading...

src/wallet/salvage.cpp

Loading...

src/wallet/test/coinselector_tests.cpp

Loading...

src/wallet/test/ismine_tests.cpp

Loading...

src/wallet/test/scriptpubkeyman_tests.cpp

Loading...

src/wallet/test/wallet_test_fixture.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...

src/wallet/test/walletdb_tests.cpp

Loading...

src/wallet/wallet.cpp

Loading...

src/wallet/wallettool.cpp

Loading...