Paths

Table of Contentst

Differential D9630

Split SetHDChain into AddHDChain and LoadHDChain
ClosedPublic
Actions

Authored by PiRK on Jun 4 2021, 15:48.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC1147f7663bec: Split SetHDChain into AddHDChain and LoadHDChain

Summary

Remove the memonly bool and follow our typical Add and Load pattern.

This is a backport of core#19046 [1/3]
https://github.com/bitcoin/bitcoin/pull/19046/commits/0122fbab4c340b23ae56173de6c5ab866ba25ab8

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 4 2021, 15:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2021, 15:48

PiRK requested review of this revision.Jun 4 2021, 15:48

teamcity edited the summary of this revision. (Show Details)Jun 4 2021, 15:49

PiRK added a child revision: D9631: Split SetActiveScriptPubKeyMan into Add/LoadActiveScriptPubKeyMan.Jun 4 2021, 15:52

Harbormaster completed remote builds in B15907: Diff 28756.Jun 4 2021, 16:03

majcosta added a subscriber: majcosta.Jun 4 2021, 19:07

majcosta accepted this revision.Jun 4 2021, 19:09

This revision is now accepted and ready to land.Jun 4 2021, 19:09

Closed by commit rABC1147f7663bec: Split SetHDChain into AddHDChain and LoadHDChain (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyJun 7 2021, 06:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1147f7663bec: Split SetHDChain into AddHDChain and LoadHDChain.

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.h

9 lines

scriptpubkeyman.cpp

31 lines

walletdb.cpp

3 lines

Diff 28781

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

Split SetHDChain into AddHDChain and LoadHDChainClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28781

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/walletdb.cpp

Split SetHDChain into AddHDChain and LoadHDChain
ClosedPublic
Actions

Revision Contents
Changeset List