Differential D9634

[avalanche] Fix threading issue in processor_tests.cpp
ClosedPublic
Actions

Authored by Fabien on Jun 4 2021, 19:32.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC13e9dcd14d5a: [avalanche] Fix threading issue in processor_tests.cpp

Summary

The test called the PeerManager directly instead of using the processor
interface that holds the appropriated locks.

Test Plan

With Clang and Debug:

ninja check-avalanche

Run the TSAN build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_tsan_peermanager

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15912
Build 31724: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-diff · build-clang-tidy
Build 31723: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 4 2021, 19:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2021, 19:32

Fabien requested review of this revision.Jun 4 2021, 19:32

@bot build-tsan

Fabien added a task: Restricted Maniphest Task.Jun 4 2021, 19:32

teamcity awarded a token.Jun 4 2021, 19:33

Harbormaster completed remote builds in B15912: Diff 28762.Jun 4 2021, 19:45

Fabien mentioned this in D9633: Fix threading issue in processor_tests.cpp.Jun 4 2021, 20:03

deadalnix accepted this revision.Jun 4 2021, 20:46

This revision is now accepted and ready to land.Jun 4 2021, 20:46

Closed by commit rABC13e9dcd14d5a: [avalanche] Fix threading issue in processor_tests.cpp (authored by Fabien). · Explain WhyJun 5 2021, 07:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC13e9dcd14d5a: [avalanche] Fix threading issue in processor_tests.cpp.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

15 lines

Diff 28762

View Options

src/avalanche/test/processor_tests.cpp

[avalanche] Fix threading issue in processor_tests.cppClosedPublicActions