Differential D9646

[avalanche] Extract a proof verification facility from the RPC
ClosedPublic
Actions

Authored by Fabien on Jun 8 2021, 12:39.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC10b624ffb4f5: [avalanche] Extract a proof verification facility from the RPC

Summary

This makes it possible to reuse the verification from other RPCs and
return consistent messages. There is no change in behavior.

Depends on D9649.

Ref T1611.

Test Plan

./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 8 2021, 12:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2021, 12:40

Fabien requested review of this revision.Jun 8 2021, 12:40

Harbormaster completed remote builds in B15937: Diff 28804.Jun 8 2021, 12:47

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[0m[0;32mwallet_importdescriptors.py             | ✓ Passed  | 7 s
[0m[0;32mwallet_importmulti.py                   | ✓ Passed  | 6 s
[0m[0;32mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                 | ✓ Passed  | 4 s
[0m[0;32mwallet_labels.py                        | ✓ Passed  | 3 s
[0m[0;32mwallet_listreceivedby.py                | ✓ Passed  | 19 s
[0m[0;32mwallet_listsinceblock.py                | ✓ Passed  | 6 s
[0m[0;32mwallet_listtransactions.py              | ✓ Passed  | 9 s
[0m[0;32mwallet_multiwallet.py                   | ✓ Passed  | 19 s
[0m[0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 18 s
[0m[0;32mwallet_reorgsrestore.py                 | ✓ Passed  | 5 s
[0m[0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 7 s
[0m[0;32mwallet_txn_clone.py                     | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py               | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 4 s
[0m[0;32mwallet_watchonly.py                     | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli            | ✓ Passed  | 1 s
[0m[0;32mwallet_zapwallettxes.py                 | ✓ Passed  | 6 s
[0m[1m
ALL                                     | ✓ Passed  | 1381 s (accumulated) 
[0mRuntime: 278 s

----------------------------------------------------------------------
Ran 5 tests in 0.002s

OK

[28/453] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[30/453] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[200/453] Running seeder test suite
PASSED: seeder test suite
[204/453] Running avalanche test suite
PASSED: avalanche test suite
[208/453] Running pow test suite
PASSED: pow test suite
[210/453] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[352/453] bitcoin: testing wallet_tests
FAILED: src/test/CMakeFiles/check-bitcoin-wallet_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-wallet_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=wallet_tests --logger=HRF,message:JUNIT,message,bitcoin-wallet_tests.xml --catch_system_errors=no
pure virtual method called
terminate called without an active exception
Aborted (core dumped)
[448/453] Running secp256k1 test suite
PASSED: secp256k1 test suite
[450/453] Running utility command for check-bitcoin-coins_tests
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Unrelated failure

Fabien edited the summary of this revision. (Show Details)Jun 8 2021, 14:14

Fabien added a parent revision: D9649: [avalanche] Make the deserialization error code consistent between RPCs.

Rebase on D9649 to get more factorized code

Harbormaster completed remote builds in B15941: Diff 28808.Jun 8 2021, 14:31

PiRK accepted this revision.Jun 8 2021, 15:19

This revision is now accepted and ready to land.Jun 8 2021, 15:19

Closed by commit rABC10b624ffb4f5: [avalanche] Extract a proof verification facility from the RPC (authored by Fabien). · Explain WhyJun 9 2021, 07:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC10b624ffb4f5: [avalanche] Extract a proof verification facility from the RPC.