Differential D9666

[refactor] use MAX_MONEY constant instead of magic number
ClosedPublic
Actions

Authored by majcosta on Jun 11 2021, 10:38.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCcf92888087fb: [refactor] use MAX_MONEY constant instead of magic number

Summary

as title

Test Plan

ninja all check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cull_magic_number

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15976
Build 31851: Build Diff	build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 31850: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 11 2021, 10:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2021, 10:38

majcosta requested review of this revision.Jun 11 2021, 10:38

Harbormaster completed remote builds in B15976: Diff 28861.Jun 11 2021, 10:52

PiRK accepted this revision.Jun 11 2021, 12:16

This revision is now accepted and ready to land.Jun 11 2021, 12:16

Closed by commit rABCcf92888087fb: [refactor] use MAX_MONEY constant instead of magic number (authored by majcosta). · Explain WhyJun 11 2021, 12:49

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCcf92888087fb: [refactor] use MAX_MONEY constant instead of magic number.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

messages.py

2 lines

Diff 28861

View Options

test/functional/test_framework/messages.py

[refactor] use MAX_MONEY constant instead of magic numberClosedPublicActions